Issue In Conjunction With Streams Mod

Locked
Daugvolf
Posts: 2
Joined: Wed Feb 28, 2018 2:45 am

Issue In Conjunction With Streams Mod

Post by Daugvolf » Wed Feb 28, 2018 2:50 am

I've been trying to gauge how stable Millenaire is before adding it to my pack, so I've been generating a lot of worlds and one thing I've noticed is how frequently Millenaire villages spawn on top of flowing streams from the Streams mod. I'd say 75% of streams end up with a village smack on top. Also whenever this happens it produces this error:

Code: Select all

[21:38:13] [Server thread/INFO] [FML]: CLIENT Trying to set null block
[21:38:13] [Server thread/INFO] [FML]: CLIENT java.lang.Exception
	at org.millenaire.common.utilities.WorldUtilities.setBlockAndMetadata(WorldUtilities.java:530)
	at org.millenaire.common.utilities.WorldUtilities.setBlockAndMetadata(WorldUtilities.java:557)
	at org.millenaire.common.buildingplan.BuildingBlock.build(BuildingBlock.java:252)
	at org.millenaire.common.buildingplan.BuildingPlan.build(BuildingPlan.java:529)
	at org.millenaire.common.buildingplan.BuildingPlanSet.buildLocation(BuildingPlanSet.java:41)
	at org.millenaire.common.world.WorldGenVillage.generateVillage(WorldGenVillage.java:403)
	at org.millenaire.common.world.WorldGenVillage.generateVillageAtPoint(WorldGenVillage.java:566)
	at org.millenaire.common.world.WorldGenVillage.generate(WorldGenVillage.java:176)
	at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
	at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1016)
	at net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:987)
	at net.minecraft.world.gen.ChunkProviderServer.func_186025_d(ChunkProviderServer.java:157)
	at net.minecraft.server.management.PlayerChunkMapEntry.func_187268_a(PlayerChunkMapEntry.java:126)
	at net.minecraft.server.management.PlayerChunkMap.func_72693_b(PlayerChunkMap.java:220)
	at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:227)
	at WorldServerOF.func_72835_b(WorldServerOF.java:37)
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:754)
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:666)
	at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:252)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
	at java.lang.Thread.run(Unknown Source)
[21:38:13] [Server thread/INFO] [FML]: CLIENT Repeat exception x2: null
If I hang out near a village spawned on a stream I'll eventually (Within about 30 minutes) crash with an out of memory error - Perhaps an issue with pathing through the flowing streams?

ProsperCraft
Posts: 94
Joined: Sat Aug 03, 2013 5:22 pm
Contact:

Re: Issue In Conjunction With Streams Mod

Post by ProsperCraft » Wed Feb 28, 2018 3:50 am

I assume you are using 1.12.2.

We are not having this problem on our server, we are using BOP worldgen, with streams and millenaire.

Here is a link to my pack. https://minecraft.curseforge.com/projects/towncraft

ProsperCraft
Posts: 94
Joined: Sat Aug 03, 2013 5:22 pm
Contact:

Re: Issue In Conjunction With Streams Mod

Post by ProsperCraft » Wed Feb 28, 2018 7:43 am

I spent several hours flying around today to see if I could reproduce the issue, I could not, here are screenshots of villages right next to streams.
2018-02-27_21.48.54.png
2018-02-27_21.48.54.png (2.85 MiB) Viewed 687 times
2018-02-27_21.09.00.png
2018-02-27_21.09.00.png (1.62 MiB) Viewed 687 times
2018-02-27_20.53.29.png
2018-02-27_20.53.29.png (1.21 MiB) Viewed 687 times

ProsperCraft
Posts: 94
Joined: Sat Aug 03, 2013 5:22 pm
Contact:

Re: Issue In Conjunction With Streams Mod

Post by ProsperCraft » Wed Feb 28, 2018 7:44 am

2018-02-28_00.31.25.png
2018-02-28_00.31.25.png (2.08 MiB) Viewed 687 times

Daugvolf
Posts: 2
Joined: Wed Feb 28, 2018 2:45 am

Re: Issue In Conjunction With Streams Mod

Post by Daugvolf » Wed Feb 28, 2018 9:05 pm

Thanks for confirming - If you're not seeing the problem then it's definitely a compatibility issue between mods in my pack, so I'll need to perform further testing. It may be a problem with Open Terrain Generator.

MoonCutter2B
Posts: 221
Joined: Tue Jun 11, 2013 5:56 am

Re: Issue In Conjunction With Streams Mod

Post by MoonCutter2B » Thu Mar 01, 2018 1:38 pm

A problem with naming biomes?
There is a suggestion to add a more advanced biome check when spawning villages. Not sure how strict i will be but I hope it will be configurable.

Anyway if you have a chance pls check what biome(s) there is in the village area, most important is around the village center. You don't have to check every block but a few samples could help.

Locked